They are legit, they just aren't deductible and haven't been at the Federal level since TCJA passed.  Some states still allow employee business expenses as a deduction.

The max allowed to teachers is still that whopping $ 250 above the line.  The IRS *did* just liberalize  what could be included in those expenses (think PPE costs), but the limit is the same.