So, there were no net earnings attributable to the excess in 2023, because the contribution for was Tax Year 2023, but the money was contributed and earned in 2024?

Roth IRA contributions aren't really reportable for the tax year, since it isn't deducted. It seems all your taxpayer has is 2024 activities that are reportable. The contribution is moot.